Added AttributedText property to Button #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
G'day Jeff! Haha! Thanks so much for that! That's a fantastic idea! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Tim,
Nice work on this project. I'm not sure if you're interested in this PR but I think its a crime when UI elements don't support NSAttributedString. Its such an important part of good UI code as it simplifies having to set soooo many properties all manually. Here is a simple PR that adds an attributed string property. Most of the code changes are in the sample app, not your library.
A sample screenshot as well, this attributed string isn't pretty, but it gets the idea across.
Thanks,
Jeff