AdminerEvo variants#172
Closed
letorbi wants to merge 2 commits intoTimWolla:masterfrom
letorbi:adminer-evo
Closed
Conversation
Author
|
Just out of interest: Could you explain, why this PR hasn't been merged? I'd like to learn from my mistakes, so that future PRs hopefully have a better quality. |
|
@letorbi, AdminerEvo is dead. |
Author
|
OK, wasn't aware that this changed recently. Thanks for the update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds two variants for (AdminerEvo](https://github.com/adminerevo/adminerevo) to mitigate the issues due to the depreciation of the original Adminer. They are named as follows:
Apart from the repo URL and the release version only the SSH256 hash and commit ID have been changed in the Dockerfiles.
The helper scripts have been updated as well. I've tested them, but since I don't have any experience with maintaining Docker images, these should be checked by a more experienced person.