refactor: move incremental back#2256
Merged
triceo merged 11 commits intoTimefoldAI:mainfrom Apr 21, 2026
Merged
Conversation
TomCools
reviewed
Apr 21, 2026
TomCools
reviewed
Apr 21, 2026
Contributor
TomCools
left a comment
TomCools
left a comment
There was a problem hiding this comment.
Docs OK for me. Can't speak to the solver code itself. Leave that up to @Christopher-Chianelli
Contributor
There was a problem hiding this comment.
Pull request overview
Moves incremental score calculation back into core (away from the Enterprise service hook) and updates documentation/licensing references accordingly.
Changes:
- Introduces core
IncrementalScoreDirector/IncrementalScoreDirectorFactoryand wires them intoScoreDirectorFactoryFactory. - Updates tests to cover incremental score calculation configuration/custom properties and corruption analysis paths.
- Refreshes docs/README/workflows to reflect new license manager and edition/feature gating.
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/src/modules/ROOT/pages/upgrading-timefold-solver/upgrade-from-v1.adoc | Updates upgrade guidance around incremental calculators and explainability. |
| docs/src/modules/ROOT/pages/constraints-and-score/score-calculation.adoc | Adjusts edition gating for incremental score analysis section. |
| docs/src/modules/ROOT/pages/commercial-editions/installation.adoc | Updates license acquisition and env var/file naming guidance. |
| docs/src/modules/ROOT/pages/commercial-editions/commercial-editions.adoc | Updates feature matrix entries. |
| docs/src/modules/ROOT/nav.adoc | Adjusts navigation for incremental score calculation. |
| core/src/test/java/ai/timefold/solver/core/impl/solver/DefaultSolverTest.java | Adds incremental score calculator tests and corruption-analysis assertions. |
| core/src/test/java/ai/timefold/solver/core/impl/score/director/ScoreDirectorFactoryFactoryTest.java | Adds incremental factory/custom-properties tests and config validation. |
| core/src/main/java/ai/timefold/solver/core/impl/score/director/incremental/IncrementalScoreDirectorFactory.java | New core factory for incremental score director. |
| core/src/main/java/ai/timefold/solver/core/impl/score/director/incremental/IncrementalScoreDirector.java | New core incremental score director + constraint match registration support. |
| core/src/main/java/ai/timefold/solver/core/impl/score/director/ScoreDirectorFactoryFactory.java | Switches incremental path to the new core factory. |
| core/src/main/java/ai/timefold/solver/core/enterprise/TimefoldSolverEnterpriseService.java | Removes incremental score calculator feature hook and updates messaging. |
| core/src/main/java/ai/timefold/solver/core/config/score/director/ScoreDirectorFactoryConfig.java | Removes “Enterprise-only” notes for incremental score calculator config. |
| core/src/main/java/ai/timefold/solver/core/api/score/calculator/IncrementalScoreCalculator.java | Removes “Enterprise-only” note from API Javadoc. |
| core/src/main/java/ai/timefold/solver/core/api/score/calculator/ConstraintMatchRegistry.java | Updates Javadoc around explainability/edition behavior. |
| core/src/main/java/ai/timefold/solver/core/api/score/calculator/AnalyzableIncrementalScoreCalculator.java | Updates Javadoc around explainability/edition behavior. |
| README.adoc | Updates edition descriptions and license-manager link. |
| .github/workflows/release-changelog-template.md | Updates license link. |
| .github/workflows/pull_request_secure.yml | Renames license env var used in CI. |
Christopher-Chianelli
approved these changes
Apr 21, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #2255 (review)