chore: split random at the start of step so results are reproducible across higher thread counts#2259
Merged
triceo merged 8 commits intoTimefoldAI:mainfrom Apr 30, 2026
Conversation
Christopher-Chianelli
temporarily deployed
to
internal
GitHub Actions
Inactive
triceo
reviewed
Apr 23, 2026
Collaborator
triceo
left a comment
triceo
left a comment
There was a problem hiding this comment.
First read through the code.
This allows move iterators to generate additional moves without affecting the random (and thus reach the same result when those moves are not generated provided the same number of steps).
Christopher-Chianelli
force-pushed
the
perf/split-random
branch
from
08e3883 to
b39b4d3
Compare
Christopher-Chianelli
temporarily deployed
to
internal
GitHub Actions
Inactive
Christopher-Chianelli
temporarily deployed
to
internal
GitHub Actions
Inactive
Christopher-Chianelli
temporarily deployed
to
internal
GitHub Actions
Inactive
triceo
requested changes
Apr 29, 2026
Collaborator
There was a problem hiding this comment.
All comments need resolving. Also, I am missing some docs changes:
- Effective move speed needs to be explained in multi-threaded documentation. Especially the seeming contradiction of effective speed going down with more move threads being added.
- The format of several logging messages has changed (or will change) as a result of this PR. Let's do a quick grep of the docs, in case they're shown anywhere.
- Check for the Random configuration options; if we mention them in the docs, those mentions need to disappear.
Also, Sonar.
Christopher-Chianelli
temporarily deployed
to
internal
GitHub Actions
Inactive
Christopher-Chianelli
temporarily deployed
to
internal
GitHub Actions
Inactive
Christopher-Chianelli
temporarily deployed
to
internal
GitHub Actions
Inactive
Christopher-Chianelli
temporarily deployed
to
internal
GitHub Actions
Inactive
triceo
approved these changes
Apr 29, 2026
Collaborator
triceo
left a comment
triceo
left a comment
There was a problem hiding this comment.
CI is failing because of Javadoc.
After that, LGTM.
Christopher-Chianelli
temporarily deployed
to
internal
GitHub Actions
Inactive
Christopher-Chianelli
temporarily deployed
to
internal
GitHub Actions
Inactive
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.