refactor: introduce incremental constraint collectors for improved performance#2270
Draft
triceo wants to merge 6 commits intoTimefoldAI:mainfrom
Draft
refactor: introduce incremental constraint collectors for improved performance#2270triceo wants to merge 6 commits intoTimefoldAI:mainfrom
triceo wants to merge 6 commits intoTimefoldAI:mainfrom
Conversation
|
3e5d3e0 to
a69c7c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Still a lot of work to do, but early PoCs look promising.
This benchmark run proves there are no regressions from adding the incremental support to the GroupNode:
https://github.com/TimefoldAI/timefold-solver-benchmarks/actions/runs/25095715799/job/73533079940
Another benchmark will be run when the collectors are upgraded to the incremental mechanism.