Merged
Conversation
…teps. Also fix compilation warnings with ommstuff.cpp
Collaborator
Author
|
@jayponder -- I submitted this PR to go directly into your master branch. It only touches the OpenMM stuff, though, and fixes things so it works correctly with triclinic cells. I can resubmit the PR to go to a different branch if you want me to, but I can't see a reason why this shouldn't go into master, personally. (I just don't want to screw up anything you might be working on). Let me know if I'm good to merge this to master. Thanks! |
Collaborator
Author
|
I'm going to go ahead and merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a number of issues with the OpenMM integration:
static)char*via=(you can do this withstd::string, but notchar*)system.xmlfile that can be used with OpenMM in standalone mode if you request 0 steps withdynamic_omm.