C# 2.0: Enums

[NobodysNightmare]

As a last comment on API-breaking changes:

I was just flying over the new IPConnection.cs and noticed many occurences of ints and shorts that should be enums. I will need to review the new IPConnection later and in more detail to fully understand it, so there might be occurences that can't be expressed as enums.

However at least the enumeration_type should be an enum, because it is public and changing it later would be API-breaking.

public enum EnumerationType : byte
{
    Available,
    Connected,
    Disconnected
}

To my mind this enum should be defined outside the IPConnection class.

Other occurences (connect_reason, connection_state) might or might not be suitable as enums, but at least a change is not immediately neccessary, as they are not publicly visible.

edit: I think the response-expected-thing is also affected here, but I don't understand how this is supposed to be used, so I might be wrong.

[borg42]

The problem is, that we can not implicitely cast between enums and bytes (even if the enum is declared as a byte). So, we would need special handling for the enums. Of course i can handwrite this in the IPConnection, but there is lots of API from the Bricks and Bricklets that return some kind of "enum type".

I think i would rather have it easy to generate in this case.