This repository was archived by the owner on May 19, 2026. It is now read-only.
refactor: migrate event creation flow to use centralized eventStore#77
Merged
Conversation
- Removed the event-create-store.ts file and replaced its functionality with a new eventStore. - Updated event detail types to remove is_seat_pickable property. - Refactored seatmap and shows creation pages to utilize the new eventStore for session management. - Enhanced seatmap creation logic to handle draft data more effectively. - Implemented PUT method for updating shows while preserving existing sections and seats. - Cleaned up unused code and improved overall structure for better maintainability.
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (19)
📝 WalkthroughWalkthroughThis PR removes the Changes
Sequence Diagram(s)sequenceDiagram
participant Admin as Admin User
participant UI as Shows Edit UI
participant API as PUT /api/events/create/shows
participant Service as eventService.updateShows()
participant DB as Database (Transaction)
Admin->>UI: Submit updated shows list
UI->>API: PUT request with shows array
API->>Service: updateShows(adminId, data)
Service->>DB: BEGIN TRANSACTION
Service->>DB: Validate event ownership & status
Service->>DB: SELECT existing shows by id
alt Update existing show
Service->>DB: UPDATE eventShow (by index)
else Insert new show
Service->>DB: INSERT new eventShow
end
Service->>DB: Track kept show IDs
Service->>DB: DELETE excess shows & cascade seats/seatSections
Service->>DB: COMMIT TRANSACTION
DB-->>Service: Transaction complete
Service-->>API: Return updated shows metadata
API-->>UI: json({ data: [...shows] })
UI->>UI: Update local state, notify user
Note over Admin,DB: Sections & seats preserved for updated shows
sequenceDiagram
participant User as Customer
participant EventPage as Event Detail Page
participant Store as SeatmapPreview Component
participant SVG as SVG Canvas
User->>EventPage: Load event detail
EventPage->>Store: Render SeatmapPreview with mapConfig, stageLayout, sections
Store->>Store: Initialize container ResizeObserver
Store->>Store: Set up zoom/pan state, tooltip tracking
Store->>SVG: Render stage elements & section polygons
alt Zoom Level ≥ threshold (assigned sections)
Store->>SVG: Render individual seat dots (LOD detail)
else Zoom < threshold
Store->>SVG: Render section label, availability %, price tag
end
User->>SVG: Scroll/wheel to zoom
Store->>Store: Update zoom level (bounded)
Store->>SVG: Re-render with LOD
User->>SVG: Hover over section
Store->>Store: Update tooltip (section name, price, available)
Store->>SVG: Show tooltip overlay
Note over User,SVG: Interactive pan/zoom with responsive LOD rendering
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes The diff spans multiple architectural layers (store, service, schemas, UI components) with heterogeneous changes ranging from field removals to new complex components (SeatmapPreview with 658 lines and stateful SVG rendering). While many changes are straightforward removals or wiring updates, the new show-update transaction logic, reactive store implementation, intricate seatmap preview with LOD rendering, and validation enhancements across multiple pages require careful reasoning for correctness and integration consistency. Possibly related PRs
Suggested reviewers
Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This was referenced Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mô tả
Sửa lỗi khi tạo sự kiện mới do logic chưa đúng đắn.
Cải thiện lại UI và logic render seat map.
Closes #57
Loại thay đổi
Screenshots / Demo
Checklist
bun run dev)bun run check)bun run lint)bun run format)feat:,fix:,chore:,...)Summary by CodeRabbit
Release Notes
New Features
Improvements