Skip to content

MinMax not used when computing Surface sampling #180

@lasofivec

Description

@lasofivec

In tofu/geom/_comp.py in the function _Ves_get_sampleS four parameters are taken and never used: Min1, Max1, Min2, Max2. They are transformed to two list, see:

tofu/tofu/geom/_comp.py

Lines 287 to 288 in a5c8cf8

MinMax1 = np.array([Min1,Max1])
MinMax2 = np.array([Min2,Max2])

But, when calling core function for sampling they are never used. Since there is no doc, not sure what are this parameters ? Are they the limits for Phi ?

Metadata

Metadata

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions