Skip to content

setup.py build dependencies: numpy/cython and PEP recommendations #276

@Didou09

Description

@Didou09

As explained in the last comments of issue #272 :

  • pip install runs setup.py
  • setup.py, in tofu, needs numpy and cython at import time, which means the user would need to install them by hand before running pip install. We want to avoir that, pip should handle all dependencies (run and build)
  • The recommended modern solution is PEP517 and PEP518, which implies creating a tofu.toml file list build-time dependencies with proper formatting
  • The recommended solution is applicable since pip >= 18.0

To be clarified : should we still include setup(setup_requires=['cython', 'numpy']) in addition to the tofu.toml file ?

Ressources:

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions