Skip to content

Issue158 basic reflections#163

Merged
Didou09 merged 21 commits intodevelfrom
Issue158_BasicReflections
Aug 28, 2019
Merged

Issue158 basic reflections#163
Didou09 merged 21 commits intodevelfrom
Issue158_BasicReflections

Conversation

@Didou09
Copy link
Copy Markdown
Member

@Didou09 Didou09 commented Aug 28, 2019

Main changes:

  • Rays subclasses can now have added reflections (self.add_reflections())
  • Reflections can alos be extracted (instead of stored) as a list of separated cameras using Rays.get_reflections_as_cam()
  • Reflections can be of type 'specular', 'diffusive' or 'ccube'
  • The reflection type can be forced by the user (identical for all LOS of a camera) or automatically set by the Structural elements each LOS touches
  • There can be any number of reflections
  • Rays.plot() and Rays.plot_touch() have been updated to properly represent reflections
  • Rays.calc_signal() and Rays.calc_signal_from_Plasma2D() have been updated to account for reflections with a user-provided coefficient

Minor technical changes:

  • Rays.dgeom['indout'][0,:] now refers to the global index of each structure (as in config.lStruct)

Other changes:

  • Operator overloading of _repr_ of all tofu objects with attribute get_summary()

Bug fixes:

  • There was a minor bug in the Rays._complete_dX12() method for 1D non-aligned cases, fixed

Issues fixed:

Perspectives:

  • Several types of reflections should be allowed to co-exist, with separate coefficients

VEZINET Didier added 21 commits August 26, 2019 12:42
…orking. Now bug in Rays._complete_dX12() for CamLOS1D from reflections
…used to return only posivitive parallel components)
…ys_plot() => Rays._get_plotL() => tf.geom._comp.LOS_CrossProj(), TBF
… dimension, and updated Rays._get_plotL() and tf.geom._comp.LOS_PRMin() accordingly => test and update tf.geom._plot.Rays_plot() and Rays.plot()
…ug found in tofu/geom/_sampling_tools.pyx => opened issue #160
…ling of reflections. TODO: test / check consistency of indout and debug unit tests for Rays._get_plotlL()
…mpute_kInOut, debugged and tested, and reflection type is inferred from Struct in config
@Didou09 Didou09 self-assigned this Aug 28, 2019
@codecov-io
Copy link
Copy Markdown

codecov-io commented Aug 28, 2019

Codecov Report

Merging #163 into devel will decrease coverage by 0.07%.
The diff coverage is 52.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel     #163      +/-   ##
==========================================
- Coverage   45.25%   45.17%   -0.08%     
==========================================
  Files          70       70              
  Lines       20392    20614     +222     
==========================================
+ Hits         9229     9313      +84     
- Misses      11163    11301     +138
Impacted Files Coverage Δ
tofu/version.py 100% <ø> (ø) ⬆️
tofu/imas2tofu/_core.py 0.74% <0%> (-0.01%) ⬇️
tofu/data/_core.py 41.06% <0%> (ø) ⬆️
tofu/data/_plot.py 91.15% <100%> (ø) ⬆️
tofu/tests/tests02_data/tests03_core.py 99.08% <100%> (ø) ⬆️
tofu/utils.py 48.86% <20%> (-0.05%) ⬇️
tofu/geom/_core.py 64.7% <43.33%> (-1.99%) ⬇️
tofu/geom/_plot.py 65.48% <57.14%> (ø) ⬆️
tofu/geom/_comp.py 60.38% <73.39%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc1ab1d...c2c38d8. Read the comment docs.

@Didou09 Didou09 merged commit c97d00b into devel Aug 28, 2019
@Didou09 Didou09 deleted the Issue158_BasicReflections branch August 28, 2019 18:45
@Didou09 Didou09 mentioned this pull request Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants