Skip to content

Euroscipy2019#173

Merged
Didou09 merged 23 commits intodevelfrom
Euroscipy2019
Sep 5, 2019
Merged

Euroscipy2019#173
Didou09 merged 23 commits intodevelfrom
Euroscipy2019

Conversation

@Didou09
Copy link
Copy Markdown
Member

@Didou09 Didou09 commented Sep 5, 2019

The talk has been done, this is the final version of the presentation

@Didou09 Didou09 requested a review from lasofivec September 5, 2019 11:44
@Didou09 Didou09 self-assigned this Sep 5, 2019
Copy link
Copy Markdown
Collaborator

@lasofivec lasofivec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you (@Didou09) added some extra files?
There are compilations files that shoudn't be part of the PR. I'm gonna change this.

@Didou09
Copy link
Copy Markdown
Member Author

Didou09 commented Sep 5, 2019

You're right, I added compiled files by mistake yesterday,
Thanks for removing them

_LT = [1,3,0]
_LRES = [-3,-3,0]
_LLOS = [5,5,0]
_LT = [3,3,0]
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is probably shouldn't be part of the PR. We can leave it if you want @Didou09, but for cleaningness maybe you want to remove it ?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hum, not sure, it's good to have easy access to typical becnhmark input

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@codecov-io
Copy link
Copy Markdown

codecov-io commented Sep 5, 2019

Codecov Report

Merging #173 into devel will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            devel     #173   +/-   ##
=======================================
  Coverage   45.16%   45.16%           
=======================================
  Files          70       70           
  Lines       20608    20608           
=======================================
  Hits         9307     9307           
  Misses      11301    11301

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1eefdc8...fb4b02a. Read the comment docs.

@Didou09
Copy link
Copy Markdown
Member Author

Didou09 commented Sep 5, 2019

Any more changes ? I'm gonna accept the pull request

@lasofivec
Copy link
Copy Markdown
Collaborator

You can ofc :) but I did do a comment in the code (see in this same thread above).

@Didou09 Didou09 merged commit 129cae4 into devel Sep 5, 2019
@Didou09 Didou09 deleted the Euroscipy2019 branch September 5, 2019 15:09
@Didou09 Didou09 mentioned this pull request Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants