Skip to content

[black] formatted comp file#182

Merged
Didou09 merged 4 commits intodevelfrom
Issue30_pep8
Sep 10, 2019
Merged

[black] formatted comp file#182
Didou09 merged 4 commits intodevelfrom
Issue30_pep8

Conversation

@lasofivec
Copy link
Copy Markdown
Collaborator

PARTIALLY Fixes #30

In order to solve Issue #30, I applied black to the file: tofu/geom/_comp.py

Since this is a time consuming process, I rather check if the first first file fits the rest of the team's expectation (notably @Didou09). If so next PR will be with all *.py files, changed analogically.

@lasofivec lasofivec requested a review from Didou09 September 9, 2019 17:00
@lasofivec lasofivec self-assigned this Sep 9, 2019
@pep8speaks
Copy link
Copy Markdown

pep8speaks commented Sep 9, 2019

Hello @lasofivec! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 889:28: E203 whitespace before ':'

Comment last updated at 2019-09-10 08:20:41 UTC

@lasofivec
Copy link
Copy Markdown
Collaborator Author

Hello @lasofivec! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 889:28: E203 whitespace before ':'

Comment last updated at 2019-09-09 17:02:59 UTC

This is a know difference between flake8 and PEP8 rules. I decide we can ignore it

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #182 into devel will increase coverage by <.01%.
The diff coverage is 63.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel     #182      +/-   ##
==========================================
+ Coverage   45.16%   45.17%   +<.01%     
==========================================
  Files          70       70              
  Lines       20608    20611       +3     
==========================================
+ Hits         9307     9310       +3     
  Misses      11301    11301
Impacted Files Coverage Δ
tofu/geom/_core.py 64.7% <100%> (ø) ⬆️
tofu/geom/_comp.py 60.3% <63.7%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5c8cf8...025af3e. Read the comment docs.

@Didou09
Copy link
Copy Markdown
Member

Didou09 commented Sep 10, 2019

Good moves :-)

@Didou09 Didou09 merged commit 807da74 into devel Sep 10, 2019
@lasofivec
Copy link
Copy Markdown
Collaborator Author

@Didou09 did you see in detail the code ?
Should I do the same changes for all *.py files? There are other tools to do the pep8 formatting it's a matter of taste :)

@Didou09 Didou09 mentioned this pull request Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants