Skip to content

update in setup.py#184

Merged
Didou09 merged 1 commit intodevelfrom
Issue183_setuppy
Sep 12, 2019
Merged

update in setup.py#184
Didou09 merged 1 commit intodevelfrom
Issue183_setuppy

Conversation

@lasofivec
Copy link
Copy Markdown
Collaborator

Fixes #183

  • Now we don't specify the gcc compiler for Mac OSX (or any OS). It will use the system's default compiler. This fixes the above mentioned Issue as well as prevent the need for a patch (on ITER servers)

  • Passed black on the setup.py file.

@lasofivec lasofivec requested a review from Didou09 September 11, 2019 09:10
@lasofivec lasofivec self-assigned this Sep 11, 2019
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #184 into devel will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            devel     #184   +/-   ##
=======================================
  Coverage   45.17%   45.17%           
=======================================
  Files          70       70           
  Lines       20611    20611           
=======================================
  Hits         9310     9310           
  Misses      11301    11301

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 807da74...fae6b47. Read the comment docs.

Copy link
Copy Markdown
Member

@Didou09 Didou09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me,
except: I don't see where we check for homebrew, do we ?

Ok with the PEP8 changes too

Comment thread setup.py
os.environ['CXX'] = 'g++-8'
else:
os.environ['CC'] = 'gcc'
os.environ['CXX'] = 'g++'
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Didou09 here we used to force which gcc was being used. By default homebrew's gcc is gcc-8.
Now we let the system's gcc

@Didou09 Didou09 merged commit b476c26 into devel Sep 12, 2019
@lasofivec lasofivec deleted the Issue183_setuppy branch September 12, 2019 09:36
@Didou09 Didou09 mentioned this pull request Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants