Conversation
Codecov Report
@@ Coverage Diff @@
## devel #184 +/- ##
=======================================
Coverage 45.17% 45.17%
=======================================
Files 70 70
Lines 20611 20611
=======================================
Hits 9310 9310
Misses 11301 11301Continue to review full report at Codecov.
|
Didou09
reviewed
Sep 11, 2019
Member
Didou09
left a comment
There was a problem hiding this comment.
Ok for me,
except: I don't see where we check for homebrew, do we ?
Ok with the PEP8 changes too
lasofivec
commented
Sep 11, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #183
Now we don't specify the
gcccompiler for Mac OSX (or any OS). It will use the system's default compiler. This fixes the above mentioned Issue as well as prevent the need for a patch (on ITER servers)Passed black on the
setup.pyfile.