Skip to content

Issue188 calc in out isoflux more flexible#191

Merged
Didou09 merged 12 commits intodevelfrom
Issue188_calckInOutIsofluxMoreFlexible
Sep 13, 2019
Merged

Issue188 calc in out isoflux more flexible#191
Didou09 merged 12 commits intodevelfrom
Issue188_calckInOutIsofluxMoreFlexible

Conversation

@Didou09
Copy link
Copy Markdown
Member

@Didou09 Didou09 commented Sep 12, 2019

Main change:

input args (lPoly, lVIn) of tf.geom.Rays.calc_kInOut_Isoflux() can now be arrays or list indifferently (more user-friendly)

@Didou09 Didou09 self-assigned this Sep 12, 2019
@codecov-io
Copy link
Copy Markdown

codecov-io commented Sep 12, 2019

Codecov Report

Merging #191 into devel will decrease coverage by 0.05%.
The diff coverage is 37.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel     #191      +/-   ##
==========================================
- Coverage   45.17%   45.11%   -0.06%     
==========================================
  Files          70       70              
  Lines       20611    20644      +33     
==========================================
+ Hits         9310     9313       +3     
- Misses      11301    11331      +30
Impacted Files Coverage Δ
tofu/version.py 100% <ø> (ø) ⬆️
tofu/geom/_core.py 64% <32.09%> (-0.71%) ⬇️
tofu/tests/tests01_geom/tests03_core.py 90.02% <64.7%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b476c26...100762b. Read the comment docs.

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #191 into devel will decrease coverage by 0.06%.
The diff coverage is 28%.

Impacted file tree graph

@@            Coverage Diff            @@
##            devel    #191      +/-   ##
=========================================
- Coverage   45.17%   45.1%   -0.07%     
=========================================
  Files          70      70              
  Lines       20611   20648      +37     
=========================================
+ Hits         9310    9314       +4     
- Misses      11301   11334      +33
Impacted Files Coverage Δ
tofu/version.py 100% <ø> (ø) ⬆️
tofu/tests/tests01_geom/tests03_core.py 89.63% <100%> (ø) ⬆️
tofu/geom/_core.py 64.02% <26.02%> (-0.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b476c26...ccb8d6b. Read the comment docs.

@pep8speaks
Copy link
Copy Markdown

pep8speaks commented Sep 13, 2019

Hello @Didou09! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-09-13 07:52:52 UTC

@Didou09 Didou09 merged commit 96c8cd8 into devel Sep 13, 2019
@Didou09 Didou09 deleted the Issue188_calckInOutIsofluxMoreFlexible branch September 13, 2019 08:20
@Didou09 Didou09 mentioned this pull request Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants