Skip to content

Issue187 duplicate init for coils pf#192

Merged
Didou09 merged 4 commits intodevelfrom
Issue187_DuplicateInitForCoilsPF
Sep 13, 2019
Merged

Issue187 duplicate init for coils pf#192
Didou09 merged 4 commits intodevelfrom
Issue187_DuplicateInitForCoilsPF

Conversation

@Didou09
Copy link
Copy Markdown
Member

@Didou09 Didou09 commented Sep 13, 2019

Fixes, in devel, Issue #187

Extra verbose tf.geom.CoilsPF.init() removed
Less verbose one kept, with mobile=False enforced

@Didou09 Didou09 requested a review from lasofivec September 13, 2019 09:59
@Didou09 Didou09 self-assigned this Sep 13, 2019
@pep8speaks
Copy link
Copy Markdown

pep8speaks commented Sep 13, 2019

Hello @Didou09! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-09-13 12:50:14 UTC

@Didou09 Didou09 changed the base branch from master to devel September 13, 2019 10:00
@codecov-io
Copy link
Copy Markdown

codecov-io commented Sep 13, 2019

Codecov Report

Merging #192 into devel will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           devel     #192      +/-   ##
=========================================
+ Coverage   45.1%   45.11%   +<.01%     
=========================================
  Files         70       70              
  Lines      20643    20639       -4     
=========================================
- Hits        9312     9311       -1     
+ Misses     11331    11328       -3
Impacted Files Coverage Δ
tofu/version.py 100% <ø> (ø) ⬆️
tofu/geom/_core.py 64.05% <100%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55356de...06eabc5. Read the comment docs.

_LT = [3,3,0]
_LRES = [-3, -3, 0]
_LLOS = [5, 5, 0]
_LT = [3, 3, 0]
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useless but ok

@Didou09 Didou09 merged commit f8a08c4 into devel Sep 13, 2019
@Didou09 Didou09 deleted the Issue187_DuplicateInitForCoilsPF branch September 13, 2019 13:23
@Didou09 Didou09 mentioned this pull request Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants