[Issue 189] Rays._checkformat_inputs_dgeom() is now a method instead …#193
Merged
[Issue 189] Rays._checkformat_inputs_dgeom() is now a method instead …#193
Conversation
…of a classmethod (cls -> self)
|
Hello @Didou09! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2019-09-13 12:23:06 UTC |
Codecov Report
@@ Coverage Diff @@
## devel #193 +/- ##
=========================================
- Coverage 45.11% 45.1% -0.01%
=========================================
Files 70 70
Lines 20644 20643 -1
=========================================
- Hits 9313 9312 -1
Misses 11331 11331
Continue to review full report at Codecov.
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rays._checkformat_inputs_dgeom() is now a method (self) instead of a classmethod (cls)
Fixes, in devel, issue #189