Skip to content

[Issue 186] the assert was on lc, not Types#194

Merged
Didou09 merged 1 commit intodevelfrom
Issue186_UnusedTypesuInGeom
Sep 13, 2019
Merged

[Issue 186] the assert was on lc, not Types#194
Didou09 merged 1 commit intodevelfrom
Issue186_UnusedTypesuInGeom

Conversation

@Didou09
Copy link
Copy Markdown
Member

@Didou09 Didou09 commented Sep 13, 2019

Fixes, in devel, Issue #186

The assert was on lc, not on Types

@Didou09 Didou09 requested a review from lasofivec September 13, 2019 11:23
@Didou09 Didou09 self-assigned this Sep 13, 2019
@codecov-io
Copy link
Copy Markdown

codecov-io commented Sep 13, 2019

Codecov Report

Merging #194 into devel will not change coverage.
The diff coverage is 50%.

Impacted file tree graph

@@           Coverage Diff           @@
##            devel     #194   +/-   ##
=======================================
  Coverage   45.11%   45.11%           
=======================================
  Files          70       70           
  Lines       20644    20644           
=======================================
  Hits         9313     9313           
  Misses      11331    11331
Impacted Files Coverage Δ
tofu/geom/_core.py 64% <0%> (ø) ⬆️
tofu/version.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96c8cd8...f5b4f05. Read the comment docs.

@Didou09
Copy link
Copy Markdown
Member Author

Didou09 commented Sep 13, 2019

Review not necessary

@Didou09 Didou09 merged commit 8d04bca into devel Sep 13, 2019
@Didou09 Didou09 deleted the Issue186_UnusedTypesuInGeom branch September 13, 2019 12:22
@Didou09 Didou09 mentioned this pull request Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants