Build docs with sphinx-gallery#195
Conversation
|
Hello @flothesof! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2019-09-13 14:40:05 UTC |
Codecov Report
@@ Coverage Diff @@
## devel #195 +/- ##
==========================================
+ Coverage 45.11% 45.11% +<.01%
==========================================
Files 70 70
Lines 20639 20640 +1
==========================================
+ Hits 9311 9312 +1
Misses 11328 11328
Continue to review full report at Codecov.
|
|
I managed to get it to work, despite the windows specific problems. Among the fixes are things like this: There are probably some more of these to be found: they cause problems on Windows! |
User specific ignore was already taken out some time ago... Somehow it sneak it way back in
| num_tot_structs += len(ss.Lim) | ||
|
|
||
| lsnvert = np.asarray(lsnvert, dtype=np.int64) | ||
| lsnvert = np.asarray(lsnvert, dtype=np.long) |
There was a problem hiding this comment.
Not sure how this affects linux users, waiting for feedback from Laura
There was a problem hiding this comment.
I'm gonna test it in my machine, could you try it also in CentOS ?
changes for PEP8 speaks
There was a problem hiding this comment.
Ok, but:
- waiting for feedback from Laura as other linux user
- IMPORTANT : we do pull requests only to devel, which our common base working branch, PR to master are only done from devel, when we decide devel is advanced / stable enough to issue a release
=> I'm switching target of PR to devel
Thanks !
|
Made changes for pep8, merged with |
lasofivec
left a comment
There was a problem hiding this comment.
Great job, working on my configs
|
Forgot to mention: the example is 🔥 |
Hi all,
this is a first draft of sphinx-gallery generation of examples.
Let me know what you think of it.
Regards,
Florian