Skip to content

[bugfix/portability] handling long types on windows#199

Merged
Didou09 merged 6 commits intodevelfrom
pr/197
Sep 27, 2019
Merged

[bugfix/portability] handling long types on windows#199
Didou09 merged 6 commits intodevelfrom
pr/197

Conversation

@lasofivec
Copy link
Copy Markdown
Collaborator

It's working now on my computer (I'll merge this to your fork first if you want @flothesof)
For the orginial PR #197

…on3 type (in py3 integers have unlimited precision)
Copy link
Copy Markdown
Contributor

@flothesof flothesof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me.

@lasofivec lasofivec changed the title windows long long [bugfix/portability] handling long types on windows Sep 25, 2019
@lasofivec
Copy link
Copy Markdown
Collaborator Author

I think @flothesof comment on PR #197 was spot on.

A better way to check this might be to convert the array to a numpy format rightaway and then inspect the dtype instead of the type?

Originally posted by @flothesof in #197 (comment)

I said that np.long is not a valid numpy type, see:

https://docs.scipy.org/doc/numpy/user/basics.types.html?highlight=long

However in older numpy versions this is not true

https://docs.scipy.org/doc/numpy-1.15.4/user/basics.types.html?highlight=long

@Didou09 Didou09 merged commit d30e7e8 into devel Sep 27, 2019
@lasofivec lasofivec deleted the pr/197 branch September 27, 2019 10:23
@Didou09 Didou09 mentioned this pull request Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants