Skip to content

Issue209 plasma2 d interpolation#210

Merged
Didou09 merged 23 commits intodevelfrom
Issue209_Plasma2DInterpolation
Oct 8, 2019
Merged

Issue209 plasma2 d interpolation#210
Didou09 merged 23 commits intodevelfrom
Issue209_Plasma2DInterpolation

Conversation

@Didou09
Copy link
Copy Markdown
Member

@Didou09 Didou09 commented Oct 8, 2019

The bug was coming from interp_t not being set

@Didou09 Didou09 self-assigned this Oct 8, 2019
@pep8speaks
Copy link
Copy Markdown

pep8speaks commented Oct 8, 2019

Hello @Didou09! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 17:1: E402 module level import not at top of file
Line 24:1: E402 module level import not at top of file
Line 25:1: E402 module level import not at top of file
Line 26:1: E402 module level import not at top of file
Line 157:69: E228 missing whitespace around modulo operator
Line 158:61: E228 missing whitespace around modulo operator
Line 159:47: E228 missing whitespace around modulo operator
Line 217:50: E228 missing whitespace around modulo operator
Line 239:69: E228 missing whitespace around modulo operator
Line 241:71: E228 missing whitespace around modulo operator
Line 284:50: E228 missing whitespace around modulo operator
Line 307:68: E228 missing whitespace around modulo operator
Line 308:60: E228 missing whitespace around modulo operator
Line 309:58: E228 missing whitespace around modulo operator
Line 310:61: E228 missing whitespace around modulo operator
Line 315:61: E228 missing whitespace around modulo operator
Line 316:49: E228 missing whitespace around modulo operator
Line 336:66: E228 missing whitespace around modulo operator
Line 345:73: E228 missing whitespace around modulo operator
Line 346:43: E228 missing whitespace around modulo operator
Line 347:59: E228 missing whitespace around modulo operator
Line 348:55: E228 missing whitespace around modulo operator
Line 608:47: E228 missing whitespace around modulo operator
Line 835:62: E228 missing whitespace around modulo operator
Line 837:38: E228 missing whitespace around modulo operator
Line 983:44: E228 missing whitespace around modulo operator
Line 984:44: E228 missing whitespace around modulo operator
Line 985:46: E228 missing whitespace around modulo operator

Comment last updated at 2019-10-08 08:20:53 UTC

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #210 into devel will decrease coverage by 0.97%.
The diff coverage is 13.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel     #210      +/-   ##
==========================================
- Coverage   45.11%   44.14%   -0.98%     
==========================================
  Files          70       71       +1     
  Lines       20640    21296     +656     
==========================================
+ Hits         9312     9401      +89     
- Misses      11328    11895     +567
Impacted Files Coverage Δ
tofu/version.py 100% <100%> (ø) ⬆️
tofu/data/__init__.py 100% <100%> (ø) ⬆️
tofu/data/_core_new.py 13.47% <13.47%> (ø)
tofu/data/_core.py 41.03% <33.33%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c65a988...55f8314. Read the comment docs.

@Didou09 Didou09 merged commit 99ae9de into devel Oct 8, 2019
@Didou09 Didou09 deleted the Issue209_Plasma2DInterpolation branch October 8, 2019 08:35
@Didou09
Copy link
Copy Markdown
Member Author

Didou09 commented Oct 8, 2019

Fixes, in devel, issue #209

lasofivec added a commit that referenced this pull request Nov 4, 2019
lasofivec added a commit that referenced this pull request Nov 4, 2019
removed useless files introduced in PR #210
@lasofivec
Copy link
Copy Markdown
Collaborator

done

@Didou09 Didou09 mentioned this pull request Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants