Skip to content

[Issue211] Added calc_LOS_length_in_isoflux()#212

Merged
Didou09 merged 5 commits intodevelfrom
Issue211_ToolsPtsCamLOS
Oct 8, 2019
Merged

[Issue211] Added calc_LOS_length_in_isoflux()#212
Didou09 merged 5 commits intodevelfrom
Issue211_ToolsPtsCamLOS

Conversation

@Didou09
Copy link
Copy Markdown
Member

@Didou09 Didou09 commented Oct 8, 2019

Three functions added to tf.geom.Rays:

  • calc_length_in_isoflux() : compute the length inside a set of isoflux surfaces of each LOS
  • calc_min_geom_radius(): compute the minimal geometrical radius (impact parameter) of each LOS
  • calc_min_rho_from_Plasma2D(): compute the minimum normalized radius (or any field with a minimum on the axis) for each LOS

Fixes, in devel, issue #211

@Didou09 Didou09 self-assigned this Oct 8, 2019
@pep8speaks
Copy link
Copy Markdown

pep8speaks commented Oct 8, 2019

Hello @Didou09! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-10-08 11:20:06 UTC

@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 8, 2019

Codecov Report

Merging #212 into devel will decrease coverage by 0.05%.
The diff coverage is 12.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel     #212      +/-   ##
==========================================
- Coverage   44.14%   44.09%   -0.06%     
==========================================
  Files          71       71              
  Lines       21296    21327      +31     
==========================================
+ Hits         9401     9404       +3     
- Misses      11895    11923      +28
Impacted Files Coverage Δ
tofu/version.py 100% <100%> (ø) ⬆️
tofu/geom/_core.py 63.47% <9.67%> (-0.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99ae9de...13190fa. Read the comment docs.

@Didou09 Didou09 merged commit 93ae5c5 into devel Oct 8, 2019
@Didou09 Didou09 deleted the Issue211_ToolsPtsCamLOS branch October 8, 2019 12:13
@Didou09 Didou09 mentioned this pull request Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants