Setup.py should not cythonize extensions except when building. #221#222
Merged
lasofivec merged 2 commits intoToFuProject:develfrom Oct 29, 2019
Merged
Conversation
|
Hello @Louwrensth! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2019-10-29 10:47:26 UTC |
…oject#221 Cython’s build_ext module runs cythonize as part of the build process: https://cython.readthedocs.io/en/latest/src/userguide/source_files_and_compilation.html#distributing-cython-modules
Louwrensth
force-pushed
the
Issue221_pypi_tarball_not_clean
branch
from
f20fa5d to
688423c
Compare
lasofivec
approved these changes
Oct 29, 2019
Collaborator
|
I wasn't aware of this. Thank you ! |
Member
|
Thanks @lasofivec for taking care of this, |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cython’s build_ext module runs cythonize as part of the build process:
https://cython.readthedocs.io/en/latest/src/userguide/source_files_and_compilation.html#distributing-cython-modules