Skip to content

Br/add more field lines#223

Closed
jmoralesFusion wants to merge 5 commits intodevelfrom
br/add_more_field_lines
Closed

Br/add more field lines#223
jmoralesFusion wants to merge 5 commits intodevelfrom
br/add_more_field_lines

Conversation

@jmoralesFusion
Copy link
Copy Markdown
Collaborator

No description provided.

@pep8speaks
Copy link
Copy Markdown

pep8speaks commented Oct 30, 2019

Hello @jmoralesFusion! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 7:61: E502 the backslash is redundant between brackets
Line 13:1: E265 block comment should start with '# '
Line 14:80: E501 line too long (82 > 79 characters)
Line 15:1: E265 block comment should start with '# '
Line 17:1: E265 block comment should start with '# '
Line 18:1: E402 module level import not at top of file

Line 682:41: E128 continuation line under-indented for visual indent
Line 683:41: E128 continuation line under-indented for visual indent
Line 688:80: E501 line too long (102 > 79 characters)
Line 689:13: E265 block comment should start with '# '
Line 692:9: E265 block comment should start with '# '
Line 692:80: E501 line too long (90 > 79 characters)
Line 693:9: E265 block comment should start with '# '
Line 694:19: E221 multiple spaces before operator
Line 694:80: E501 line too long (81 > 79 characters)
Line 695:80: E501 line too long (88 > 79 characters)
Line 696:19: E221 multiple spaces before operator
Line 696:80: E501 line too long (93 > 79 characters)
Line 697:21: E221 multiple spaces before operator
Line 697:80: E501 line too long (93 > 79 characters)
Line 705:15: E221 multiple spaces before operator
Line 720:56: E128 continuation line under-indented for visual indent
Line 721:56: E128 continuation line under-indented for visual indent
Line 723:56: E128 continuation line under-indented for visual indent
Line 724:56: E128 continuation line under-indented for visual indent
Line 732:60: E128 continuation line under-indented for visual indent
Line 733:60: E128 continuation line under-indented for visual indent
Line 734:60: E128 continuation line under-indented for visual indent
Line 735:80: E501 line too long (81 > 79 characters)
Line 736:60: E128 continuation line under-indented for visual indent
Line 737:60: E128 continuation line under-indented for visual indent
Line 738:60: E128 continuation line under-indented for visual indent
Line 741:30: E231 missing whitespace after ','
Line 747:80: E501 line too long (83 > 79 characters)
Line 751:80: E501 line too long (84 > 79 characters)
Line 777:80: E501 line too long (85 > 79 characters)

Line 129:31: E231 missing whitespace after ','
Line 129:43: E231 missing whitespace after ','
Line 151:29: E127 continuation line over-indented for visual indent
Line 151:30: E225 missing whitespace around operator
Line 154:29: E127 continuation line over-indented for visual indent
Line 154:30: E225 missing whitespace around operator

Comment last updated at 2019-10-31 17:54:58 UTC

@lasofivec
Copy link
Copy Markdown
Collaborator

Hi Jorge, thanks for the PR.
Could you please see the comments from pep8speaks at least on the mag files (since there are comments on the old code that doesn't come from your changes.
FTR, I updated the documentation on how to contribute

@jmoralesFusion
Copy link
Copy Markdown
Collaborator Author

Hello I am closing this pull request to make a new one. Some user suggested some improvement.
Cheers,
Jorge

@jmoralesFusion jmoralesFusion deleted the br/add_more_field_lines branch October 31, 2019 18:02
@Didou09 Didou09 mentioned this pull request Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants