Correct path for README files search in setup

[munechika-koyo]

I changed a little code to get rid of bug.
I would appreciate it if you could make sure it is fine and merge it to master branch.

Laura's comments
This pull requests could be divided into two:

• Solving issue Windows setup's path of README file #224 : fixed path of README file in setup.py
• Introducing new ITER geometry "B4"

[pep8speaks]

Hello @munechika-koyo! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-11-05 16:51:59 UTC

[lasofivec]

Hi Koyo, thanks for the PR!
Is this solving issue #224 ?

A couple of remarks:

• please always do the pull requests to devel. The master branch will be only changed around twice per year to maintain the stability of the library.
• If you see the comments above, you will see a automatic bot called pep8-speaks that comments on your coding style. I am aware that here it tells you a remark from code that you didn't actually code, and this is due to the fact that we didn't have this tool before and that there are still some areas where the coding style is still not perfect. But just as an exercise: would you mind correcting these errors. Here, pep8-speaks found the following issues:

In the file tofu/geom/utils.py:
Line 629:25: E231 missing whitespace after ':'

if we see the line 629:

'A2': {'Exp':_ExpITER,

it should be changed to:

'A2': {'Exp': _ExpITER,

(notice the withespace after the :)

• I updated the documentation: see mostly the contributing section. I precisely added some comments on the devel/master comments and on the pep8-speaks

[lasofivec]

this is better ! thanks !

[lasofivec]

Last but not least, since this PR is also introducing the new geometry, could you please describe in the original post what's new on the geometry ? I added the name but some comments could be great.

[lasofivec]

I opened issue #227

[lasofivec]

@Didou09 @munechika-koyo since now there is a branch specific to the new geometry addition Issue220_NewITERConfig I feel like this PR should only include the changes to the setup.py.
Event if it will be a small change, I think is good practice to separate the different changes on different PRs.
What do you think ? I can make the changes and close the PR if you argee

[Didou09]

I totally agree, let's separate into elementary changes, it's way cleaner

[munechika-koyo]

I also agree with @lasofivec
That makes sense.

[munechika-koyo]

I raised the new PR #245.
Is this fine?

[lasofivec]

Yes thank you Koyo !!
I'll correct this branch and merge it.