Skip to content

Issue228 default separator to dict#229

Merged
Didou09 merged 6 commits intodevelfrom
Issue228_DefaultSeparatorToDict
Nov 4, 2019
Merged

Issue228 default separator to dict#229
Didou09 merged 6 commits intodevelfrom
Issue228_DefaultSeparatorToDict

Conversation

@Didou09
Copy link
Copy Markdown
Member

@Didou09 Didou09 commented Nov 4, 2019

Fixes in devel issue #228

Default separator is now '.' instead of '_'
=> renders better the nested dict structure
=> allows to use '_' in attributes names

@Didou09 Didou09 self-assigned this Nov 4, 2019
@pep8speaks
Copy link
Copy Markdown

pep8speaks commented Nov 4, 2019

Hello @Didou09! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-11-04 13:19:05 UTC

@Didou09
Copy link
Copy Markdown
Member Author

Didou09 commented Nov 4, 2019

Only python 2.7 not passing
=> merge because we are dropping python 2.7 (cf. PR #231 )

@Didou09 Didou09 merged commit 75da71c into devel Nov 4, 2019
@Didou09 Didou09 deleted the Issue228_DefaultSeparatorToDict branch November 4, 2019 13:39
Copy link
Copy Markdown
Collaborator

@lasofivec lasofivec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the changes, even if I have no actual comment.
I think for code sanity is better if we always review each other's PR.

@Didou09
Copy link
Copy Markdown
Member Author

Didou09 commented Nov 4, 2019

Agreed, I'll try to stick to that from now on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants