Merged
Conversation
Member
Author
|
Only python 2.7 not passing |
lasofivec
reviewed
Nov 4, 2019
Collaborator
lasofivec
left a comment
There was a problem hiding this comment.
I reviewed the changes, even if I have no actual comment.
I think for code sanity is better if we always review each other's PR.
Member
Author
|
Agreed, I'll try to stick to that from now on |
This was referenced Nov 19, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes in devel issue #228
Default separator is now
'.'instead of'_'=> renders better the nested dict structure
=> allows to use
'_'in attributes names