Skip to content

Dropping support of Python 2.7#234

Merged
Didou09 merged 5 commits intodevelfrom
dropping-py2
Nov 4, 2019
Merged

Dropping support of Python 2.7#234
Didou09 merged 5 commits intodevelfrom
dropping-py2

Conversation

@lasofivec
Copy link
Copy Markdown
Collaborator

@lasofivec lasofivec commented Nov 4, 2019

Solves Issue #230

Dropping support of python 2.7:

  • no longer being tested in travis
  • no longer packaged in conda
  • merged _GG02 and _GG03 into the _GG file
  • updated README file accordingly
  • dropped funcsigs dependency
  • made necessary changes in setup.py

@lasofivec lasofivec requested a review from Didou09 November 4, 2019 14:49
@lasofivec lasofivec self-assigned this Nov 4, 2019
Didou09
Didou09 approved these changes Nov 4, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@Didou09 Didou09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job :-)

Comment thread README.md


python (2.7 or 3)
python (>= 3)
Copy link
Copy Markdown
Member

@Didou09 Didou09 Nov 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not >=3.5 ? or >= 3.6?

Copy link
Copy Markdown
Collaborator Author

@lasofivec lasofivec Nov 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right !

@Didou09 Didou09 merged commit fdc722e into devel Nov 4, 2019
@lasofivec lasofivec deleted the dropping-py2 branch November 4, 2019 16:16
@lasofivec lasofivec restored the dropping-py2 branch November 19, 2019 15:55
@Didou09 Didou09 mentioned this pull request Nov 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Didou09 Didou09 Didou09 approved these changes

Assignees

@lasofivec lasofivec

Labels

portability

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lasofivec @Didou09