Skip to content

Benchmarks now with python 3#238

Closed
lasofivec wants to merge 9 commits intodevelfrom
bf-py2-conda-build
Closed

Benchmarks now with python 3#238
lasofivec wants to merge 9 commits intodevelfrom
bf-py2-conda-build

Conversation

@lasofivec
Copy link
Copy Markdown
Collaborator

Updated the benchmark script: benchmarks/calc_signal_benchmark.py
so that it works with python 3, plus it reads/writes better into files.

The benchmarks are also no longer packaged

@lasofivec lasofivec requested a review from Didou09 November 4, 2019 17:23
@lasofivec lasofivec self-assigned this Nov 4, 2019
@pep8speaks
Copy link
Copy Markdown

Hello @lasofivec! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 157:49: E228 missing whitespace around modulo operator
Line 157:60: E231 missing whitespace after ','
Line 163:36: E231 missing whitespace after ','
Line 167:36: E231 missing whitespace after ','
Line 358:38: E228 missing whitespace around modulo operator
Line 361:44: E228 missing whitespace around modulo operator

@lasofivec
Copy link
Copy Markdown
Collaborator Author

Not sure how, but I did the wrong merge at some point i'm just going to close this PR

@lasofivec lasofivec closed this Nov 5, 2019
@lasofivec lasofivec deleted the bf-py2-conda-build branch November 5, 2019 17:26
@Didou09 Didou09 mentioned this pull request Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants