Conversation
Contributor
|
Sorry to bring it up again, since I started discussing this in the bug report, but what were the steps you used to check that this changes what you want? |
Didou09
approved these changes
Nov 19, 2019
Member
|
I'm merging because this PR is harmless and can only help (even though we might remove requirements.txt later, it is a simple double-safety hotfix). We'll have a more detailed and general discussion on CI / unit tests / installs in a few weeks time |
This was referenced Nov 19, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves Issue #250
Added
requirements.txtI tried on a new conda environment with python=3.7 and the latest pip installed.