[bug fix #255] found bug#257
Conversation
|
Hello @lasofivec! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2019-11-19 17:33:20 UTC |
Didou09
left a comment
Didou09
left a comment
There was a problem hiding this comment.
Good, but:
- Could you find the reason why an error was thrown with vect=None ? It should not
- ani=None should remain the default, None is neutral and means the user did not specify anything. False / True are choices that the user wants to enforce.
Please see the lines where I tagged you |
| ray_vdir[:, ii:ii+1]) | ||
| val_2d = func(pts, t=t, vect=-usbis, **fkwdargs) | ||
| sig_mv[:, ii] = np.sum(val_2d, axis=-1)*loc_eff_res[0] | ||
| sig[:, ii] = np.sum(val_2d, axis=-1)*loc_eff_res[0] |
There was a problem hiding this comment.
@Didou09 :
Could you find the reason why an error was thrown with vect=None ? It should not
It doesn't anymore. Here is the only real change in this PR, that fixes the bug.
There was a problem hiding this comment.
PS: if you see line 3319, it only happened if ani=True, minimize=hybrid, method=sum, and if you see line 2863 I took out the variable which was no longer need and verified all loops to see that this error was nowhere else.
Codecov Report
@@ Coverage Diff @@
## feature-#252 #257 +/- ##
===============================================
Coverage ? 43.91%
===============================================
Files ? 74
Lines ? 21518
Branches ? 0
===============================================
Hits ? 9449
Misses ? 12069
Partials ? 0
Continue to review full report at Codecov.
|
4 participants
Fixes #255