Conversation
|
Hello @lasofivec! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2019-11-20 08:43:17 UTC |
Didou09
left a comment
Didou09
left a comment
There was a problem hiding this comment.
Just a question on insp, I could not find where it was defined
| import scipy.integrate as scpintg | ||
|
|
||
| if sys.version[0] == "3": | ||
| from inspect import signature as insp |
There was a problem hiding this comment.
If this is suppressed too, where is insp defined ?
| @@ -1027,18 +1022,15 @@ def LOS_calc_signal( | |||
| D, u, dL, DL=DL, dLMode=dLMode, method=method, Test=Test | |||
| ) | |||
| out = insp(ff) | |||
There was a problem hiding this comment.
sorry ! you are right ! fixed
| from inspect import signature as insp | ||
| elif sys.version[0] == "2": | ||
| from inspect import getargspec as insp | ||
| from inspect import signature as insp |
Codecov Report
@@ Coverage Diff @@
## devel #258 +/- ##
==========================================
+ Coverage 43.85% 46.85% +2.99%
==========================================
Files 74 74
Lines 21462 24156 +2694
==========================================
+ Hits 9412 11318 +1906
- Misses 12050 12838 +788
Continue to review full report at Codecov.
|
4 participants
Took out all lingering
if sys.version[0]=='2':