Skip to content

Issue264 config names#265

Merged
lasofivec merged 4 commits intodevelfrom
Issue264_ConfigNames
Nov 20, 2019
Merged

Issue264 config names#265
lasofivec merged 4 commits intodevelfrom
Issue264_ConfigNames

Conversation

@Didou09
Copy link
Copy Markdown
Member

@Didou09 Didou09 commented Nov 20, 2019 •
edited
Loading

tofu.geom.utils.create_config() now has:

  • unique reference explicit config names (e.g.: 'WEST-V1', ''ITER-V2...)
  • shortcuts that also refer to these reference config names ('B2', 'ITER'...)

=> More practical and also retro-compatible

Fixes, in devel, Issue #264

@Didou09 Didou09 requested a review from lasofivec November 20, 2019 13:07
@Didou09 Didou09 self-assigned this Nov 20, 2019
@pep8speaks
Copy link
Copy Markdown

pep8speaks commented Nov 20, 2019 •
edited
Loading

Hello @Didou09! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-11-20 13:11:13 UTC

@lasofivec lasofivec merged commit 561d6ef into devel Nov 20, 2019
@Didou09 Didou09 mentioned this pull request Nov 20, 2019
Merged
@Didou09 Didou09 deleted the Issue264_ConfigNames branch November 22, 2019 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@lasofivec lasofivec lasofivec approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Didou09 Didou09

Labels

geom - improve

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Didou09 @pep8speaks @lasofivec