Issue310 more robust warning for out of vessel los

[Didou09]

Main changes:

• Try / except introduced in tf.geom.Rays._compute_dgeom() in case where some LOS have no visibility inside vessel to make sure an error during the plotting process does not stop computation
• Exception is still caught and displayed as warning

Issues:

• Fixes, in devel, issue Creating camera fails  #310

[flothesof]

I've just looked at your commit.
It looks alright to me.
However, encapsulating with a try except something that should work and actually help the user debug his camera is of great value.
It turns out that the 3D axis does not support the axis = equal option (see matplotlib/matplotlib#15382).
So fixing this instead of putting it into a try/except block would be a better way to address this, don't you think?
I'd advocate for fixing this at the core instead of your proposal.

[flothesof]

I've just found out where the problem is. Taking out line 167 in tofu/geom/_def.py solves the issue.

tofu/tofu/geom/_def.py

Line 167 in 2d9b183

ax.set_aspect(aspect="equal", adjustable='datalim')

I'm also thinking it would be great to add a unit test with a camera that has missing LOS so that our tests checks that the debug plot works.

[lasofivec]

Should we close this PR then ?

[Didou09]

Yes, you're right, PR #313 will do, this one is no use anymore