Conversation
added 20 commits
February 3, 2020 18:17
…tion and indch selection
…erferometer, polarimeter, ece, bremsstrahlung_visible, spectrometer_visible, reflectometer_profile, barometry, lh_antennas, magnetics TBC, tofuplot and tofucalc TBC
lasofivec
approved these changes
Feb 6, 2020
Collaborator
lasofivec
left a comment
lasofivec
left a comment
There was a problem hiding this comment.
It looks like this PR includes the changes of the last PR (#343), so it's a bit hard to see what changes are introduced only by this enhancement.
It is always better to start from devel unless it is not an independent feature addition.
Otherwise, awesome work :)
Member
Author
|
Youu're absolutely right on every point:
But in this particular case, I needed these changes to fix this issue (there cumulative so to speak), so I had no choice ;-) |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main changes:
setup.py installtime thanks to the use ofentry_points. both scripts were moved totofu/scripts/https://python-packaging.readthedocs.io/en/latest/command-line-scripts.html
https://chriswarrick.com/blog/2014/09/15/python-apps-the-right-way-entry_points-and-scripts/
https://stackoverflow.com/questions/774824/explain-python-entry-points
Issues:
Fixes, in devel, issue #344