Issue349 new imas reflectometer profile

[Didou09]

Main changes:

• The IMAS data dictionnary has changed a bit since the last version, this is a minor update for ids reflectometer_profile
• Made sure tofuplot and tofucalc remain operational even without installation

[pep8speaks]

Hello @Didou09! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-02-07 10:57:34 UTC

[codecov-io]

Codecov Report

Merging #350 into devel will decrease coverage by 0.07%.
The diff coverage is 9.09%.

@@            Coverage Diff             @@
##            devel     #350      +/-   ##
==========================================
- Coverage   39.65%   39.58%   -0.08%     
==========================================
  Files          81       81              
  Lines       24355    24363       +8     
==========================================
- Hits         9659     9644      -15     
- Misses      14696    14719      +23

Impacted Files	Coverage Δ
tofu/imas2tofu/_core.py	0.65% <ø> (ø)	⬆️
tofu/scripts/tofuplot.py	0% <0%> (ø)	⬆️
tofu/scripts/tofucalc.py	0% <0%> (ø)	⬆️
tofu/version.py	100% <100%> (ø)	⬆️
tofu/data/_core_new.py	13.15% <0%> (-0.47%)	⬇️
tofu/geom/_core_optics.py	14.35% <0%> (-0.35%)	⬇️
tofu/geom/_comp.py	59.69% <0%> (-0.22%)	⬇️
tofu/data/_core.py	38.79% <0%> (-0.18%)	⬇️
tofu/geom/_plot.py	65.55% <0%> (-0.11%)	⬇️
tofu/geom/_core.py	63.06% <0%> (-0.11%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4a1177...099b760. Read the comment docs.

[lasofivec]

where is _HERE first defined ?

[Didou09]

one line above

[Didou09]

Here we are taking _HERE as the directory of the module:
_HERE = os.path.abspath(os.path.dirname(__file__))

and then we go 2 parents directories up:
_HERE = os.path.dirname(os.path.dirname(_HERE))

That's because tofuplot and tofucalc were moved from the root directory down to tofu/scripts

[lasofivec]

yes sorry, somehow i didn't see the line above (twice)

[lasofivec]

same question...

[Didou09]

same answer ;-)