Skip to content

Issue #357 Made allow_pickle available to user#358

Merged
lasofivec merged 3 commits intodevelfrom
Issue357_AllowPickle
Mar 2, 2020
Merged

Issue #357 Made allow_pickle available to user#358
lasofivec merged 3 commits intodevelfrom
Issue357_AllowPickle

Conversation

@Didou09
Copy link
Copy Markdown
Member

@Didou09 Didou09 commented Feb 27, 2020

Motivation:

Safety and backward compatibility for old saved files, see:
https://stackoverflow.com/questions/41696360/numpy-consequences-of-using-np-save-with-allow-pickle-false

Main Changes:

  • parameter allow_pickle, fed to np.load(), is now available to the user using tf.load()

Issues:

Fixes, in devel, issue #357

@Didou09 Didou09 requested a review from lasofivec February 27, 2020 15:35
@Didou09 Didou09 self-assigned this Feb 27, 2020
@Didou09 Didou09 changed the title [Issue357] Made allow_pickle available to user Issue #357 Made allow_pickle available to user Feb 27, 2020
@pep8speaks
Copy link
Copy Markdown

pep8speaks commented Feb 27, 2020

Hello @Didou09! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-02-27 17:14:14 UTC

@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 27, 2020

Codecov Report

Merging #358 into devel will increase coverage by <.01%.
The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel     #358      +/-   ##
==========================================
+ Coverage   39.32%   39.32%   +<.01%     
==========================================
  Files          84       84              
  Lines       24584    24586       +2     
==========================================
+ Hits         9667     9669       +2     
  Misses      14917    14917
Impacted Files Coverage Δ
tofu/version.py 100% <100%> (ø) ⬆️
tofu/utils.py 47.2% <85.71%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a5ca76...90cefa7. Read the comment docs.

@lasofivec lasofivec merged commit d30992a into devel Mar 2, 2020
@lasofivec lasofivec deleted the Issue357_AllowPickle branch March 2, 2020 10:47
@Didou09 Didou09 mentioned this pull request Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants