Merged
Conversation
…rom user's .tofu/
Codecov Report
@@ Coverage Diff @@
## devel #361 +/- ##
=======================================
Coverage 39.24% 39.24%
=======================================
Files 85 85
Lines 24625 24625
=======================================
Hits 9663 9663
Misses 14962 14962
Continue to review full report at Codecov.
|
lasofivec
approved these changes
Mar 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Realized :
os.chdir(...)
import
was not robust enough, the system can chdir in a separate terminal and the import ay not see the proper module
Replaced by a more robust
1/ temporary modification of the sys.path
2/ use of importlib library
Option 2 seems safer after some reading.
Also @lasofivec , I pushed changes to ne-doc for the bash commands, but could not build the doc because I can't install a Sphinx dependency here, could you build and push to gh-pages ?
Also: added draft for release notes for 1.4.3