Skip to content

Chore!: bump sqlglot to v26.16.0#4172

Merged
georgesittas merged 2 commits intomainfrom
jo/bump_sqlglot_to_v26_15_0
Apr 22, 2025
Merged

Chore!: bump sqlglot to v26.16.0#4172
georgesittas merged 2 commits intomainfrom
jo/bump_sqlglot_to_v26_15_0

Conversation

@georgesittas
Copy link
Contributor

@erindru could you double check that the Athena changes caused by this upgrade are legit? Based on this comment, I reckon that they should be good, just not quite sure.

@georgesittas georgesittas requested a review from erindru April 17, 2025 19:15
@georgesittas
Copy link
Contributor Author

georgesittas commented Apr 18, 2025

Trying to debug the Trino failure, I stumbled across this:

-> self.cursor.execute(sql, **kwargs)
(Pdb) p sql
'CREATE TABLE IF NOT EXISTS "datalake"."test_schema_56j263jm"."test_table" ("id" INTEGER, "ds" VARCHAR) WITH (PARTITIONED_BY=ARRAY[\'"ds"\'])'
(Pdb) n
trino.exceptions.TrinoUserError: TrinoUserError(type=USER_ERROR, name=INVALID_TABLE_PROPERTY, message="Partition columns ["ds"] not present in schema", query_id=20250418_172014_00040_8kpha)

I think it's yelling because the double quotes (") are being treated as part of the column's name, which isn't correct. This feels like a bug after all, but I'll let this PR be for a while.

For example, manually executing this instead works:

(Pdb) self.cursor.execute('CREATE TABLE IF NOT EXISTS "datalake"."test_schema_56j263jm"."test_table" ("id" INTEGER, "ds" VARCHAR) WITH (PARTITIONED_BY=ARRAY[\'ds\'])', **kwargs)
<trino.dbapi.Cursor object at 0x160e0b800>

@georgesittas georgesittas force-pushed the jo/bump_sqlglot_to_v26_15_0 branch from 70a61d7 to 0efd20c Compare April 22, 2025 09:17
@georgesittas georgesittas changed the title Chore!: bump sqlglot to v26.15.0 Chore!: bump sqlglot to v26.16.0 Apr 22, 2025
@georgesittas
Copy link
Contributor Author

Bumped to v26.16.0 instead

@georgesittas georgesittas requested a review from a team April 22, 2025 09:18
@georgesittas georgesittas merged commit b46a68c into main Apr 22, 2025
22 checks passed
@georgesittas georgesittas deleted the jo/bump_sqlglot_to_v26_15_0 branch April 22, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants