Added support for addon weapons being correctly saved to loadouts #557
Conversation
…ort for addon weapons being correctly saved to custom made loadouts. Of course they are also getting correctly loaded, when loading the loadout. It works dynamically. If the users are adding addon weapons into the addons.json file, these weapons automatically get the feature to be saved and loaded correctly from the custom made loadouts :)
…ort for addon weapons being correctly saved to custom made loadouts. Of course they are also getting correctly loaded, when loading the loadout. It works dynamically. If the users are adding addon weapons into the addons.json file, these weapons automatically get the feature to be saved and loaded correctly from the custom made loadouts :)
|
Out of curiosity, what does this do that #494 doesn’t do? |
If i am being completely honest... I did not saw that someone already made a pull request for this bug 😅. Please excuse me. I did saw it after making my pull request |
lol no worries! I’m the one who caused the issue in the first place, so I’m very clearly not a perfect coder. I always want to support other solutions. (Tbh I was hopeful you had something else. I’ll take a look to be sure. IMO for this project more features = more better) I’ll probably compare these two PRs at some point and see if there’s any improvements I can make. vMenu is a free, open source, fan made project. I’m here solely for the love of the game. If every single PR I ever made got rewritten better by someone else, that would be fantastic because it would mean vMenu is better and I could learn something. Unfortunately the number of vMenu devs is very small compared to the player base, so for the most part if you want a feature you have to write it yourself. |
Thats cool to hear! Yeah i guessed so too... I saw a bug report from like 2 years ago where someone mentioned the bug that addon weapons don't get saved in custom loadouts. Just like i guessed it didn't get fixed and thats why i saw the opportunity to fix it myself. Like I said i didnt saw you pull request. But yeah we will see what the devs will be doing with your or my pull request. sorry for my bad englisch :) |
2 participants
By editing the ValidWeapons.cs and the WeaponOptions.cs, i added support for addon weapons being correctly saved to custom made loadouts. Of course they are also getting correctly loaded, when loading the loadout.
It works dynamically. If the users are adding addon weapons into the addons.json file, these weapons automatically get the feature to be saved and loaded correctly from the custom made loadouts :)
Deleted previous pull request because a file was missing :)