Fix a few crashes and list files with unknown types#2
Open
jnm2 wants to merge 15 commits intoTomahnaProject:masterfrom
Open
Fix a few crashes and list files with unknown types#2jnm2 wants to merge 15 commits intoTomahnaProject:masterfrom
jnm2 wants to merge 15 commits intoTomahnaProject:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Great project! Thanks for starting something. I miss Revelator and was overjoyed to see an open-source project.
I wanted to extract in-game audio. This required a change so that files with unknown types are listed. I'm still figuring out how the
.ss0and.seqfiles relate to each other, but there's plenty of Ogg Vorbis audio content inside the.ss0files.I also fixed a pretty bad bug. Due to a mistaken assumption that a folder would not contain its own files if it also has subfolders, the app was failing to read the file entries, but the file entries were there. The app did not read the file entries and thus did not increment the index past the file entries, and thus when it tried to read subsequent folder entries, the index was still pointing at file entries. After this was fixed, there were some chances to simplify the code since there's no difference between reading folders anywhere now, whether root m4b, or folders with subfolders, or folders without subfolders.