Skip to content

Bugfix: better display and settings control#17

Merged
Ahzyuan merged 2 commits intov0.1.xfrom
bugfix/better-display
Mar 9, 2025
Merged

Bugfix: better display and settings control#17
Ahzyuan merged 2 commits intov0.1.xfrom
bugfix/better-display

Conversation

@Ahzyuan
Copy link
Copy Markdown
Member

@Ahzyuan Ahzyuan commented Mar 9, 2025

📋 Summary

Important

  • This PR fixes a bug.
  • This PR adds something new.
  • This PR is not a code change (e.g. README, typos, ...)
  • This PR has been tested.

📝 Changes

Details
  • torchmeter/display.py: Fixed the validation check mechanism for custom settings, and the setting application was extracted as an independent logic to better meet the requirements of various initialization parameters. In addition, repeat_footer was set as a class property and the acceptable types were extended, making the setting truly convenient and efficient. In the table rendering, keep_custom_name and keep_new_col are added to control whether the custom column names and new columns persist during the program's execution.
  • torchmeter/engine.py: fix module scanning bug, cause named_children() will squash repeat modules into one.

@Ahzyuan Ahzyuan self-assigned this Mar 9, 2025
@Ahzyuan Ahzyuan merged commit 7416e9a into v0.1.x Mar 9, 2025
@Ahzyuan Ahzyuan deleted the bugfix/better-display branch March 9, 2025 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant