Fix fairchem model interface given v2 release.

[CompRhys]

Ci for fairchem model broke after https://github.com/facebookresearch/fairchem/releases/tag/fairchem_core-2.0.0. We will pin in CI to 1.10 stop the error.

The interface should be updated to work with v2 release.

[CompRhys]

I am not a big fan of the indent everything fix, but I don't have any better ideas.

you could remove the model here and instead port it upstream into fairchem which i like a lot and believe should be done with the other models as well (into their respective repos). pinging @zulissimeta and @lbluque to see if you'd be open to having a torch_sim.models.ModelInterface subclass in fairchem?

Hi @janosh and @orionarcher 👋 we're in the process of doing a codebase refactor, but this is surely something we'd be interested in looking into the few weeks after.

Originally posted by @lbluque in #187 (comment)

[lbluque]

For now I think pinning to 1.10 is the way to go. Moving forward, I am happy to chat about integrating a FAIRChem interface to torch_sim into fairchem - we are excited to test this out with our new models 😃

[samblau]

My group is itching to use Torch-Sim with UMA. If Torch-Sim developers like @janosh and @orionarcher and fairchem developers like @lbluque can make the upgrade a priority, it would be hugely appreciated and IMO heavily benefit both parties!

[CompRhys]

There is a delay in prioritizing this locally given our EGIP model builds on GemNet layer code from fairchemv1 which was removed as far as I understand moving to fairchemv2. Once we work out how we want to decouple EGIP from fairchem then more likely we will get to this.

[AdeeshKolluru]

Hi @samblau, I think we can temporarily support both v1 and the latest version of fairchem as separate models with their own optional dependencies. This way we have backward compatibility with the older models.

@lbluque @rayg1234 @mshuaibii It seems like the fairchem team plans to implement GemNet as well in v2? What's the tentative timeline of that? Do you also plan to get rid of torch_sparse dependency in GemNet?

[mshuaibii]

Yes, we do plan on incorporating GemNet-OC back into the repo. We don't have a specific timeline yet as we are still sorting out other priorities. Of course if you or anyone else in the community wanted to take a stab we would happily welcome that and provide feedback.

As far as torch_sparse, we would prefer getting rid of these dependencies since they've often made the install process difficult for users. But if there's no way around it we can have it as an optional dependancy for users wanting gemnet.

[AdeeshKolluru]

Cool, I'll take a shot at it today then.

[mshuaibii]

Amazing - thank you!

Happy to kick off training on our end once that's in place to reproduce say OC20 results.