use "SimState" type rather than Self in state.py#191
Closed
curtischong wants to merge 1 commit intomainfrom
Closed
use "SimState" type rather than Self in state.py#191curtischong wants to merge 1 commit intomainfrom
"SimState" type rather than Self in state.py#191curtischong wants to merge 1 commit intomainfrom
Conversation
2 tasks
curtischong
changed the title
"SimState" type rather than Self in state.py
cast list of simstates more rename Self to SimState linter fixes
CompRhys
reviewed
May 14, 2025
| self.cell = value.transpose(-2, -1) | ||
|
|
||
| def clone(self) -> Self: | ||
| def clone(self) -> "SimState": |
Member
There was a problem hiding this comment.
I think typing as Self is correct per the pep? https://peps.python.org/pep-0673/
Collaborator
There was a problem hiding this comment.
agree Self is better here (as in higher fidelity). it will correctly resolve to child classes of SimState like DeformState
Collaborator
Author
There was a problem hiding this comment.
interesting. pylance gave me errors for it though. maybe ty might not complain
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a few type errors I've been getting via pylance.
I've talked to Janosh about the larger typing issues in the codebase but I currently do not have time to look into those right now. So I want to merge this PR in so others don't think I'm fixing all of the other typing issues.
Checklist
Before a pull request can be merged, the following items must be checked:
Run ruff on your code.
We highly recommended installing the pre-commit hooks running in CI locally to speedup the development process. Simply run
pip install pre-commit && pre-commit installto install the hooks which will check your code before each commit.