Conversation
… structlog. swap scripts to use logging over prints.
orionarcher
approved these changes
Mar 2, 2026
Collaborator
orionarcher
left a comment
orionarcher
left a comment
There was a problem hiding this comment.
what do we want to log and at what level?
IMO this is a good first pass at logging, I would just advocate that we also log each new batch, as mentioned in the comments.
I think the shared file is fine, perhaps just document the logging behavior in the docs somewhere or maybe include it in the intro tutorial.
Co-authored-by: Orion Cohen <27712051+orionarcher@users.noreply.github.com> Signed-off-by: Rhys Goodall <rhys.goodall@outlook.com>
Signed-off-by: Rhys Goodall <rhys.goodall@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Log all the things.
using f-strings in logs are bad because it forces them to instantiate even if filtered, should really remove the ruff rule ignore added.
logs by default are written to a shared file which might be weird if multiple things are run simultaneously.
what do we want to log and at what level?