Add log line clarifying BinningAutoBatcher is initialization-only in optimize#489
Merged
Add log line clarifying BinningAutoBatcher is initialization-only in optimize#489
Conversation
…reopen_trajectories" This reverts commit 3463ece.
Drop self.trajectories references before opening new handles so CPython's reference counting finalizes old HDF5 file objects before the new opens. Remove the incomplete TODO workaround from TorchSimTrajectory.__init__ that was a band-aid for the same issue.
Collaborator
Author
|
@CompRhys this was not ready to merge as was part of an incomplete second change. Next time can mark as draft. Will deal with file handling in a separate PR. |
Member
|
oops, I thought the deleted TODO was that the list creation above fixed any issue. |
Collaborator
Author
|
unclear... I was having some HDF5 issues and this was the vibe coded solution that didn't actually fix the problem. More digging needed. Certainly possible these changes are valid but did not address my problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
logger.infocall inoptimize(runners.py) just before the_chunked_applycall that initializes optimizer stateMotivation
Users reading logs saw BinningAutoBatcher output and were confused about which autobatcher was active during optimization. This one-line log message removes that ambiguity with no refactoring.