Skip to content

Add Nequix model#511

Merged
CompRhys merged 8 commits intoTorchSim:mainfrom
teddykoker:nequix
Mar 18, 2026
Merged

Add Nequix model#511
CompRhys merged 8 commits intoTorchSim:mainfrom
teddykoker:nequix

Conversation

@teddykoker
Copy link
Copy Markdown
Contributor

Summary

  • Add Nequix model

Checklist

Before a pull request can be merged, the following items must be checked:

  • Doc strings have been added in the Google docstring format.
  • Run ruff on your code.
  • Tests have been added for any new functionality or bug fixes.

@abhijeetgangan abhijeetgangan requested a review from CompRhys March 17, 2026 19:11
Copy link
Copy Markdown
Member

@CompRhys CompRhys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

--
+1 why it would be nice to get better test filtering as too many tests run here for such a clean/minimal PR c.f. #435

Copy link
Copy Markdown
Member

@CompRhys CompRhys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually no nequix tests run in CI, please update test.yml

@CompRhys CompRhys dismissed their stale review March 17, 2026 19:50

this guy is a nerd

@CompRhys
Copy link
Copy Markdown
Member

^^ test failures, please ignore my dismiss review comment about myself I thought the messages we're only visible to maintainers...

@CompRhys
Copy link
Copy Markdown
Member

LGTM, happy to merge?

@teddykoker
Copy link
Copy Markdown
Contributor Author

Yup. thanks!

@CompRhys CompRhys merged commit f7a125c into TorchSim:main Mar 18, 2026
70 of 72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants