Skip to content

Sending my Production assignment_1 #1

Open
Toronto3000 wants to merge 1 commit intomainfrom
assignment_1
Open

Sending my Production assignment_1 #1
Toronto3000 wants to merge 1 commit intomainfrom
assignment_1

Conversation

@Toronto3000
Copy link
Copy Markdown
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

I have added , removing and refactoring my class codes

What did you learn from the changes you have made?

basical, I learned how to deal with multiple datasets at once , and manage all those date together trough the dat engineering process

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

not really, just all those methods leaned in class

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

multiples challenges.. I got help with the support services.

How were these code working?.

my ncode are running, but let me know if I need some corrections or adjustments, please?

A reference to a related issue in your repository (if applicable)

Checklist

  • [ x] I can confirm that my changes are working as intended
    -yes

Copy link
Copy Markdown

@xindizhang xindizhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, and excellent logging! No further changes needed.

Just one minor comment:

  • The rolling average should be calculated within each ticker, not across the entire dataset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants