Skip to content

fixed getItems() casting #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Touchie771 merged 1 commit into from
Nov 27, 2025
Merged

fixed getItems() casting #11

Touchie771 merged 1 commit into from
Nov 27, 2025

Conversation

@Touchie771
Copy link
Owner

@Touchie771 Touchie771 commented Nov 27, 2025

fixes #7

@Touchie771
Copy link
Owner Author

Touchie771 commented Nov 27, 2025

✅ LGTM! (Looks Good To Me)

This PR properly fixes issue #7:

  • Changed return type from HashSet<SlotItem> to Set<SlotItem>
  • Removed the unsafe cast that could cause ClassCastException
  • The change is minimal and focused

The wildcard import java.util.* is acceptable in this context since the file already uses multiple collection types.

This is a necessary breaking change to fix the bug. Ready to merge! 🚀

@Touchie771 Touchie771 merged commit 43d67d4 into master Nov 27, 2025
2 checks passed
@Touchie771 Touchie771 deleted the fix/get-items-casting branch November 27, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unsafe casting in getItems() method

2 participants

@Touchie771