Use Ruff ! #207
Merged
Use Ruff ! #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
commented
Apr 8, 2023
| "D205", # Not all docstrings have a short description + desrciption | ||
|
|
||
| ### FIXME (no warnings in Ruff yet: https://github.com/charliermarsh/ruff/issues/1256): | ||
| "PTH", |
Collaborator
Author
There was a problem hiding this comment.
Using pathlib instead of os.path is the modern way to go. However fixing this could introduce a bug if not careful. So I'm leaving it for later.
Avasam
added a commit
that referenced
this pull request
May 23, 2023
https://beta.ruff.rs/docs/ https://github.com/charliermarsh/ruff Massively simplify configurations and speedup linting thanks to Ruff. Adds more autofixes too. Using `pathlib` instead of `os.path` is the modern way to go. However fixing this could introduce a bug if not careful. So I'm leaving it for later. Existing related Ruff requests (nothing here is a blocker, just future improvements): - astral-sh/ruff#1256 - astral-sh/ruff#3011 - astral-sh/ruff#3072 - astral-sh/ruff#3910 - astral-sh/ruff#2419 - astral-sh/ruff#3115 - astral-sh/ruff#1904
Avasam
added a commit
that referenced
this pull request
May 23, 2023
https://beta.ruff.rs/docs/ https://github.com/charliermarsh/ruff Massively simplify configurations and speedup linting thanks to Ruff. Adds more autofixes too. Using `pathlib` instead of `os.path` is the modern way to go. However fixing this could introduce a bug if not careful. So I'm leaving it for later. Existing related Ruff requests (nothing here is a blocker, just future improvements): - astral-sh/ruff#1256 - astral-sh/ruff#3011 - astral-sh/ruff#3072 - astral-sh/ruff#3910 - astral-sh/ruff#2419 - astral-sh/ruff#3115 - astral-sh/ruff#1904
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://beta.ruff.rs/docs/
https://github.com/charliermarsh/ruff
Massively simplify configurations and speedup linting thanks to Ruff. Adds more autofixes too.
Please make sure that you agree with the linting changes. I can always disable some rules, change some configs, or open new feature requests.
Existing related Ruff requests (nothing here is a blocker, just future improvements):
N802for methods marked with@overrideastral-sh/ruff#3910isortcustom sections and ordering astral-sh/ruff#2419