Skip to content

Catch pygrabber failure when adding video input device #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Avasam merged 1 commit into from
May 22, 2023
Merged

Catch pygrabber failure when adding video input device #239

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions src/capture_method/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,12 +208,17 @@ class CameraInfo():
name: str
occupied: bool
backend: str
resolution: tuple[int, int] | None
resolution: tuple[int, int]


def get_input_device_resolution(index: int):
filter_graph = FilterGraph()
filter_graph.add_video_input_device(index)
try:
filter_graph.add_video_input_device(index)
# This can happen since OBS 29.1 DLL blocking breaking VirtualCam
# https://github.com/Toufool/AutoSplit/issues/238
except COMError:
return None
resolution = filter_graph.get_input_device().get_current_format()
filter_graph.remove_filters()
return resolution
Expand Down Expand Up @@ -242,7 +247,10 @@ async def get_camera_info(index: int, device_name: str):
# finally:
# video_capture.release()

return CameraInfo(index, device_name, False, backend, get_input_device_resolution(index))
resolution = get_input_device_resolution(index)
return CameraInfo(index, device_name, False, backend, resolution) \
if resolution is not None \
else None

future = asyncio.gather(
*[
Expand Down